Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports the display of a dial for the management of the 24h (without AM and PM) #52

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

stephanebalasse
Copy link

24-hour

Copy link
Owner

@bendavis78 bendavis78 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Please remove unnecessary files (.idea/ dir?)
  • Remove changes that only affect whitespace
  • Don't change the version number (this will be done after final merge)
  • Don't change indentation so that it's clear which lines of code have been changed

Copy link
Collaborator

@admwx7 admwx7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove editor based files - I recommend a .gitignore files in your userspace to remove them on app projects
  • remove random white space changes, indention changes, and new lines
  • L224 paper-time-picker.html is forcing this to always be 24hrs, this should be something you opt into

@masonlouchart
Copy link

I'm pretty sad that this PR was never merged. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants